[libcxx-commits] [PATCH] D117736: [libc++][P2321R2] Add vector<bool>::reference::operator=(bool) const

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D117736#3257847 <https://reviews.llvm.org/D117736#3257847>, @philnik wrote:

> (1) I couldn't find any tests for `vector<bool>::reference`. Could you tell me where they are or if there are any? If not, where should I put them?

`git grep flip libcxx/test/ | grep -v utilities/template.bitset` — no hits. So I think we don't have any tests!

They should definitely go somewhere under `libcxx/test/std/containers/sequences/vector.bool/`; I would think directly in that directory with hierarchical filenames like `reference.flip.pass.cpp`, `reference.assign.pass.cpp` (or maybe `reference.{const_,}assign_{bool,reference}.pass.cpp`, one per overload?), etc. Although I wouldn't see anything wrong with `reference/flip.pass.cpp`, `reference/assign.pass.cpp`, etc either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117736/new/

https://reviews.llvm.org/D117736