[libcxx-commits] [PATCH] D117728: [libc++] Check that gdb is linked with Python 3

Pirama Arumuga Nainar via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 19 15:46:29 PST 2022


pirama created this revision.
pirama added a reviewer: ldionne.
Herald added a subscriber: arichardson.
pirama requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The tests rely on python3 so fail when run against a gdb built with
Python 2.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117728

Files:
  libcxx/utils/libcxx/test/features.py


Index: libcxx/utils/libcxx/test/features.py
===================================================================
--- libcxx/utils/libcxx/test/features.py
+++ libcxx/utils/libcxx/test/features.py
@@ -195,6 +195,9 @@
   # Using the quit command here means that gdb itself exits, not just
   # the "python <...>" command.
   test_src = """\
+import sys
+if sys.version_info.major < 3:
+  sys.exit(1)
 try:
   gdb.Breakpoint(\"main\").commands=\"foo\"
 except AttributeError:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117728.401426.patch
Type: text/x-patch
Size: 471 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220119/35f878fc/attachment.bin>


More information about the libcxx-commits mailing list