[libcxx-commits] [PATCH] D117638: [libcxx] chrono::month_weekday should not be default constructible

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/include/__chrono/calendar.h:543
 public:
-    month_weekday() = default;
     constexpr month_weekday(const chrono::month& __mval, const chrono::weekday_indexed& __wdival) noexcept
----------------
I think this should be mentioned in the release notes. `libcxx/docs/ReleaseNotes.rst`


================
Comment at: libcxx/test/std/utilities/time/time.cal/time.cal.wdidx/time.cal.wdidx.nonmembers/streaming.pass.cpp:9
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // XFAIL: *
 
----------------
Quuxplusone wrote:
> You missed this `XFAIL: *`.
> But, looking at these XFAIL'ed tests, I'm noticing that none of them are good. They just print something to std::cout (!) and then exit without asserting anything (!!). Do we want to just delete them, and ask whoever eventually implements <chrono> to write their own tests?
I think that makes sense. These tests only give a false impression we've implemented these parts of chrono.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117638/new/

https://reviews.llvm.org/D117638