[libcxx-commits] [PATCH] D117606: [libcxx][test] Portably test that `{w, }format_context` is a specialization of `basic_format_context`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for the fix. LGTM!



================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp:110-113
+template <class Context, class charT>
+constexpr bool is_basic_format_context_specialization = false;
+template <class It, class charT>
+constexpr bool is_basic_format_context_specialization<std::basic_format_context<It, charT>, charT> = true;
----------------
CaseyCarter wrote:
> Quuxplusone wrote:
> > Primarily just to rename the lowercase template parameter `charT`.
> I when with `CharT` to be consistent with the rest of the file (which I should have done in the first place, instead of using `charT` to be consistent with the working draft).
I too prefer `CharT` since that's consistent with the other `<format>` tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117606/new/

https://reviews.llvm.org/D117606