[libcxx-commits] [PATCH] D117400: [libc++] [test] Refactor iterators.common/ctor.pass.cpp

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 401212.
Quuxplusone added a comment.

Well, this turned into quite the rabbit hole.
My new and improved ctor tests ended up triggering lots of missing constexpr, and then adding the constexpr (and some regression tests) found more bugs. I touched the tests that clearly needed regression tests for the bugs I was fixing. A followup PR should improve the remaining tests (and eliminate the remaining `"types.h"`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117400/new/

https://reviews.llvm.org/D117400

Files:
  libcxx/include/__iterator/common_iterator.h
  libcxx/test/std/iterators/predef.iterators/iterators.common/constraints.compile.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor_converting.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor_default.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor_iter.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/ctor_sentinel.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/iter_move.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/iter_swap.pass.cpp
  libcxx/test/std/iterators/predef.iterators/iterators.common/types.h
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117400.401212.patch
Type: text/x-patch
Size: 33631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220119/5627b392/attachment-0001.bin>