[libcxx-commits] [PATCH] D117608: [libcxx][test] view_interface need not derive from view_base

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 18 15:02:28 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/ranges/range.utility/view.interface/view.interface.pass.cpp:35
 
-static_assert(std::derived_from<std::ranges::view_interface<Empty>, std::ranges::view_base>);
+LIBCPP_STATIC_ASSERT(std::derived_from<std::ranges::view_interface<Empty>, std::ranges::view_base>);
 
----------------
This is late-breaking C++20, right?
If so, just delete this line (and the following blank line): there's no point testing something that we (1) shouldn't do and (2) presumably plan to change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117608/new/

https://reviews.llvm.org/D117608



More information about the libcxx-commits mailing list