[libcxx-commits] [PATCH] D116958: [libc++] Alphabetize CMakeLists.txt and module.modulemap; enforce in CI.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/lint/lit.local.cfg:3
+import pipes, sys
+config.substitutions.append(('%{python}', pipes.quote(sys.executable)))
----------------
Quuxplusone wrote:
> ldionne wrote:
> > Can you try adding `print(config.substitutions)` here and checking whether `%{libcxx}` is in there somewhere? It should.
> ```
> [('%{cxx}', '/Users/aodwyer/llvm-project/build/bin/clang++'),
>  ('%{flags}', '-isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -v --target=x86_64-apple-darwin19.6.0'),
>  ('%{compile_flags}', '-include /Users/aodwyer/llvm-project/libcxx/test/support/nasty_macros.h -nostdinc++ -I/Users/aodwyer/llvm-project/build2/include/c++/v1 -I/Users/aodwyer/llvm-project/build2/projects/libcxx/include/c++build -I/Users/aodwyer/llvm-project/libcxx/test/support -std=c++2b -fmodules -Xclang -fmodules-local-submodule-visibility -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER'),
>  ('%{link_flags}', '-lc++experimental -L/Users/aodwyer/llvm-project/build2/./lib -Wl,-rpath,/Users/aodwyer/llvm-project/build2/./lib -L/Users/aodwyer/llvm-project/build2/./lib -Wl,-rpath,/Users/aodwyer/llvm-project/build2/./lib -nodefaultlibs -lc++ -lSystem'),
>  ('%{install}', '/Users/aodwyer/llvm-project/build2'),
>  ('%{exec}', '"/Users/aodwyer/env3/bin/python3.9" /Users/aodwyer/llvm-project/libcxx/test/../utils/run.py --execdir %T --codesign_identity "" --env  -- '),
>  ('%{triple}', 'x86_64-apple-darwin19.6.0'),
>  ('%{python}', '/Users/aodwyer/env3/bin/python3.9')]
> ```
> Nope, nothing. Could this be due to my running llvm-lit manually (`./bin/llvm-lit -sv --param std=c++2b --param enable_modules=True ../libcxx/test/libcxx/lint`)? Could this be due to my build directory still having been cmake'd with `LLVM_ENABLE_PROJECTS` instead of `LLVM_ENABLE_RUNTIMES`?
I just realized the legacy testing config was still being used by default. I'm 99% sure that's why, I don't think the legacy testing config is used `cmake-bridge.cfg.in`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116958/new/

https://reviews.llvm.org/D116958