[libcxx-commits] [PATCH] D117537: [cmake] Rename `llvm_check_linker_flag` for runtime libs to avoid conflit

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with rewording.



================
Comment at: cmake/Modules/CheckCompilerAndLinkerFlag.cmake:4-5
 
-function(llvm_check_linker_flag flag dest)
+# N.B. there is a `llvm_check_linker_flag` defined in an (installed) CMake
+# module from LLVM proper that is *not* the same as this.
+function(llvm_check_compiler_and_linker_flag flag dest)
----------------
After this patch, the two functions have different names so I don't think this comment is relevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537