[libcxx-commits] [PATCH] D117537: [cmake] Rename `llvm_check_linker_flag` for runtime libs to avoid conflit

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 created this revision.
Ericson2314 added reviewers: sebastian-ne, beanz, phosek, compnerd.
Herald added subscribers: libcxx-commits, mgorny.
Herald added a project: libunwind.
Herald added a reviewer: libunwind.
Ericson2314 requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

This conflicts with a different function with the same name used by LLVM
and Clang. The latter is installed so there might be downstream users,
but this is internal-only. We therefore opt to rename this one.

This issue was reported to me in https://reviews.llvm.org/D116521#3248117 as
D116521 <https://reviews.llvm.org/D116521> made clang and llvm use the common cmake utils.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117537

Files:
  cmake/Modules/CheckCompilerAndLinkerFlag.cmake
  cmake/Modules/CheckLinkerFlag.cmake
  libcxx/cmake/config-ix.cmake
  libunwind/cmake/config-ix.cmake
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117537.400721.patch
Type: text/x-patch
Size: 4693 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220118/04d82b6b/attachment.bin>