[libcxx-commits] [PATCH] D117422: [libcxx][test] compiler options are non-portable

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 17 18:00:31 PST 2022


CaseyCarter added a comment.

In D117422#3248686 <https://reviews.llvm.org/D117422#3248686>, @ldionne wrote:

> Could we include `"test_macros.h"` and use `TEST_COMPILER_CLANG`/`TEST_COMPILER_C1XX` instead?

Done.

> (By the way, it seems to me that `TEST_COMPILER_C1XX` should be renamed to something more sensible).

Renamed "C1XX" to "MSVC" everywhere except for one comment about "Microsoft's C1XX front end" where the precision seems significant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117422/new/

https://reviews.llvm.org/D117422



More information about the libcxx-commits mailing list