[libcxx-commits] [PATCH] D117506: [libc++][P2321R2] Add specializations of basic_common_reference and common_type for pair

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:363
 
     static_assert(std::is_same_v<std::common_reference_t<A, std::tuple<B>,std::tuple<C>>, std::tuple<B>>);
+
----------------
Quuxplusone wrote:
> Should this say `common_type_t` instead of `common_reference_t`? or what's this line doing here? Ditto below.
> And/or, should this line be moved to `common_reference.compile.pass.cpp`?
> 
> Orthogonally, and probably in a separate NFC commit, can `common_type.pass.cpp` be renamed to `common_type.compile.pass.cpp` (and eliminate its `main`)?
I already thought about making this `.compile.pass.cpp`. That's why I put the `static_assert`s originally below the main in D116538. I'll make a follow-up PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117506/new/

https://reviews.llvm.org/D117506