[libcxx-commits] [PATCH] D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision as: ldionne.
ldionne added a comment.

LGTM except for Arthur's comments, which I agree with (but IMO removing the `static_assert` in `contiguous_iterator` is fine).

I checked everything and I originally thought the `libcxx/test/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp` changes were weakening the tests for libc++, but it turns out they don't.



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.move/iter_move.pass.cpp:52
 
-template <typename I>
-constexpr void unqualified_lookup_move(I first_, I last_, I result_first_, I result_last_) {
+template <typename I, typename O>
+constexpr void unqualified_lookup_move(I first_, I last_, O result_first_, O result_last_) {
----------------
Here and in the functions below too. We generally don't use a single template parameter named `O`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117368/new/

https://reviews.llvm.org/D117368