[libcxx-commits] [PATCH] D117410: [libc++] Introduce __debug_db_insert_i()

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.


================
Comment at: libcxx/include/__hash_table:648
     _LIBCPP_INLINE_VISIBILITY __hash_const_local_iterator() _NOEXCEPT : __node_(nullptr) {
-#if _LIBCPP_DEBUG_LEVEL == 2
-        __get_db()->__insert_i(this);
-#endif
+        __debug_db_insert_i(this);
     }
----------------
Quuxplusone wrote:
> philnik wrote:
> > ldionne wrote:
> > > Can you please qualify?
> > Sorry, I don't understand what you want. Qualify what?
> ADL-proof via `_VSTD::__debug_db_insert_i(this)`. Otherwise this is triggering ADL.
@philnik Sorry, I thought my request was clear since I remembered asking the same on a similar review of yours, but I might be mis-remembering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117410/new/

https://reviews.llvm.org/D117410