[libcxx-commits] [PATCH] D117410: [libc++] Introduce __debug_db_insert_i()

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 17 09:04:19 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/include/__hash_table:648
     _LIBCPP_INLINE_VISIBILITY __hash_const_local_iterator() _NOEXCEPT : __node_(nullptr) {
-#if _LIBCPP_DEBUG_LEVEL == 2
-        __get_db()->__insert_i(this);
-#endif
+        __debug_db_insert_i(this);
     }
----------------
philnik wrote:
> ldionne wrote:
> > Can you please qualify?
> Sorry, I don't understand what you want. Qualify what?
ADL-proof via `_VSTD::__debug_db_insert_i(this)`. Otherwise this is triggering ADL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117410/new/

https://reviews.llvm.org/D117410



More information about the libcxx-commits mailing list