[libcxx-commits] [PATCH] D116538: [libc++][P2321R2] Add specializations of basic_common_reference and common_type for tuple

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for the ping. It seems I missed the updates for this patch. LGTM!



================
Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp:46
           template <class> class UQual>
 struct basic_common_reference< ::Tuple<Ts...>, ::Tuple<Us...>, TQual, UQual>
     : ::Tuple_helper<void, Tuple<TQual<Ts>...>, Tuple<UQual<Us>...> > {};
----------------
Quuxplusone wrote:
> philnik wrote:
> > Mordante wrote:
> > > I noticed this while reviewing D116744, should this be disabled in C++23?
> > Why?
> > should this be disabled in C++23?
> 
> AIUI: No, but it might be helpful to the reader if we `s/Tuple/UserTuple/g`. This is basically replicating in userspace (for `Tuple`) what P2321 is now doing in library-space (for `std::tuple`); even in C++23, we want to keep testing that the userspace version still works.
Yes I initially was confused by the name and it's not a `std::tuple`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116538/new/

https://reviews.llvm.org/D116538