[libcxx-commits] [PATCH] D117402: [libc++][NFC] Use _LIBCPP_DEBUG_ASSERT in <vector>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM module some nits.



================
Comment at: libcxx/include/vector:1705
+    _LIBCPP_DEBUG_ASSERT(__get_const_db()->__find_c_from_i(_VSTD::addressof(__position)) == this,
+        "vector::insert(iterator, x) called with an iterator not referring to this vector");
     pointer __p = this->__begin_ + (__position - begin());
----------------
Style nit: Please indent this line like the others. Since it seems to fit for `emplace` it should fit for `insert`.
Same for the `insert` below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117402/new/

https://reviews.llvm.org/D117402