[libcxx-commits] [PATCH] D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 14 16:49:10 PST 2022


CaseyCarter created this revision.
CaseyCarter added a reviewer: libc++.
CaseyCarter added a project: libc++.
CaseyCarter requested review of this revision.
Herald added 1 blocking reviewer(s): libc++.

Fixup tests that believe them to be so. Most notably including some heavy refactoring in `std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp`, which now detects pointers and validates that `iterator_concept` is present only for pointers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117368

Files:
  libcxx/test/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.move/iter_move.pass.cpp
  libcxx/test/std/strings/string.view/string.view.cons/from_iterator_sentinel.pass.cpp
  libcxx/test/std/strings/string.view/string.view.deduct/iterator_sentinel.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/begin.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/end.pass.cpp
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117368.400193.patch
Type: text/x-patch
Size: 25067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220115/6819997a/attachment-0001.bin>


More information about the libcxx-commits mailing list