[libcxx-commits] [PATCH] D116815: [libc++] basic_string::resize_and_overwrite: Adopt LWG3645 (Not voted in yet)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D116815#3227945 <https://reviews.llvm.org/D116815#3227945>, @Quuxplusone wrote:

> Also, I don't know if @ldionne would want us to mention LWG3645 in some csv file, or say nothing until it's adopted (and of course that question becomes moot if we just defer landing this at all).

One of the problems with straying from our custom of never shipping something until it's in the Standard is that we don't have a process for doing it. For instance, if we make this change, do we just avoid marking the issue as implemented in the status files because there's no entry for it, and then we mark it as having been implemented since `<some LLVM version>` once the issue resolution lands in the Standard? That seems somewhat hand-wavy, and if we all died tomorrow (hopefully not), our successors wouldn't have a way to easily tell what happened without digging out this discussion.

This seems like a small enough issue that I wouldn't oppose shipping its resolution even before it's been voted officially, but if we did that, I would like to add an entry in the csv file to track issues we implement that haven't been voted yet.

[And once we have a nice place to put those, I would have a harder time fighting back people who want to ship stuff that's not in the Standard -- but I'm ready for it :-)]



================
Comment at: libcxx/include/string:985
       __resize_default_init(__n);
-      pointer __data = data();
-      __erase_to_end(_VSTD::move(__op)(__data, __n));
+      __erase_to_end(_VSTD::move(__op)(data(), +__n));
     }
----------------
WDYT about using `_LIBCPP_AUTO_CAST` here? It would be closest to the standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116815/new/

https://reviews.llvm.org/D116815