[libcxx-commits] [PATCH] D117357: [libc++] Add the "lint" scripts to libcxx-generate-files.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 14 13:25:28 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: libc++, Mordante.
Quuxplusone added a project: libc++.
Herald added subscribers: arichardson, mgorny.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

This way, there's a quick way to run them locally instead of (or before) needing to run all the tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117357

Files:
  libcxx/utils/CMakeLists.txt


Index: libcxx/utils/CMakeLists.txt
===================================================================
--- libcxx/utils/CMakeLists.txt
+++ libcxx/utils/CMakeLists.txt
@@ -15,9 +15,16 @@
     COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/generate_private_header_tests.py"
     COMMENT "Generate tests for ensuring that detail headers are private.")
 
+add_custom_target(libcxx-lint
+    COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/test/libcxx/lint/lint_cmakelists.sh.py"
+    COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/test/libcxx/lint/lint_headers.sh.py"
+    COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/test/libcxx/lint/lint_modulemap.sh.py"
+    COMMENT "Lint the header files, CMakeLists.txt, and modulemap.")
+
 add_custom_target(libcxx-generate-files
     DEPENDS libcxx-generate-public-header-transitive-inclusion-tests
             libcxx-generate-public-header-tests
             libcxx-generate-feature-test-macros
             libcxx-generate-private-header-tests
+            libcxx-lint
     COMMENT "Create all the auto-generated files in libc++ and its tests.")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117357.400132.patch
Type: text/x-patch
Size: 1121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220114/90e6971e/attachment.bin>


More information about the libcxx-commits mailing list