[libcxx-commits] [PATCH] D117327: [libc++] Fix LWG3390: move_iterator now handles move-only iterators.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 14 10:24:59 PST 2022


ldionne added a comment.

> This can't really be tested until C++20 move_iterator is completely implemented, but I'm working on that.

Can't we add a simple test with a `move_iterator` constructed from a non-copyable iterator and ensure that works? What else is missing?

This LGTM but I'd like to see tests for this, so I'll wait to see the child revisions I assume you're about to upload.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117327/new/

https://reviews.llvm.org/D117327



More information about the libcxx-commits mailing list