[libcxx-commits] [PATCH] D117268: [libc++] Install clang-tidy in docker containers and create command db symlink

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

The Docker part looks good! I think it would be best to first commit the Docker part. After that's propagated to the build nodes we can look at the part to use it.
WDYT?



================
Comment at: libcxx/utils/ci/run-buildbot:97
 
+function create-db-symlink() {
+    ln -s ${BUILD_DIR}/compile_commands.json .
----------------
I think the name db is not really descriptive, how about `create-compile_commands-symlink`?


================
Comment at: libcxx/utils/ci/run-buildbot:200
                    -DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in"
+    create-db-symlink
     check-runtimes
----------------
I wonder whether we need this in all configurations.
Secondly let's make sure we export the compile commands in the configuration where we use this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117268/new/

https://reviews.llvm.org/D117268