[libcxx-commits] [PATCH] D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with my `__to_lower` suggestion.



================
Comment at: libcxx/include/regex:1357
         {
-            __ch |= 0x20;  // tolower
+            __to_lower(__ch);  // tolower
             if ('a' <= __ch && __ch <= 'f')
----------------
Can we change this into:

```
__ch = __to_lower(__ch_);
```

Sorry I didn't spot it before. As it stands, it really looks like a bug until you realize `__ch` is passed by reference.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114813/new/

https://reviews.llvm.org/D114813