[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 13 08:42:43 PST 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion.



================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_result.pass.cpp:72
+  }
+  [[maybe_unused]] auto [in1, in2] = std::ranges::in_in_result<int, int>{1, 2};
+
----------------
Maybe remove the `[[maybe_unused]]` and test whether `in1` and `in2` have the proper values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278



More information about the libcxx-commits mailing list