[libcxx-commits] [PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

[Mark Kettenis via Phabricator via libcxx-commits]

kettenis added inline comments.


================
Comment at: libunwind/src/libunwind.cpp:70
 # warning The MIPS architecture is not supported with this ABI and environment!
+#elif defined(__sparc__) && defined(__arch64__)
+# define REGISTER_KIND Registers_sparc64
----------------
kettenis wrote:
> koakuma wrote:
> > MaskRay wrote:
> > > `__sparc64__` or `__sparcv9__`?
> > `__sparc64__` and `__sparcv9__` are clang-only, it seems. GCC doesn't define any of it.
> Correct.  IIRC defined(__sparc__) && defined(__arch64__) is what was used by Sun when their own compiler was still a thing and as far as I know all open source compilers that support 64-bit SPARC define those symbols.
And to be clear, I meant 
```
defined(__sparc__) && defined(__arch64__)
```
there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857