[libcxx-commits] [PATCH] D114813: [SystemZ][z/OS] ASCII/EBCDIC support with no coexistence

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

A couple of minor comments -- I don't see anything wrong specifically with this patch, but I'm eager to see the follow-up patches.



================
Comment at: libcxx/include/regex:1314-1322
+#if defined(__MVS__) && !defined(__NATIVE_ASCII_F)
+    #define _IS07(c) ((c & 0xF8u) == 0xF0)
+    #define _IS89(c) ((c & 0xFEu) == 0xF8)
+    #define _TOLOWER(c) (c &= 0xBF)
+#else
+    #define _IS07(c) ((c & 0xF8u) == 0x30)
+    #define _IS89(c) ((c & 0xFEu) == 0x38)
----------------
Those should be inline functions instead of macros.


================
Comment at: libcxxabi/CMakeLists.txt:272
 # Configure target flags
+add_target_flags_if_supported("-fzos-le-char-mode=ebcdic")
+
----------------
What does this flag do? Isn't it necessary only when building using EBCDIC?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114813/new/

https://reviews.llvm.org/D114813