[libcxx-commits] [PATCH] D117089: [libc++] Quick fix to remove a narrowing conversion from the in_out_result test.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 12 01:50:14 PST 2022


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe958b140ab3: [libc++] Quick fix to remove a narrowing conversion from the in_out_result test. (authored by var-const).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117089/new/

https://reviews.llvm.org/D117089

Files:
  libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp


Index: libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp
===================================================================
--- libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp
+++ libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp
@@ -53,8 +53,9 @@
   // Conversion, fundamental types.
   {
     std::ranges::in_out_result<int, bool> x = {2, false};
-    std::ranges::in_out_result<double, char> y = x;
-    assert(y.in == 2.0);
+    // FIXME(varconst): try a narrowing conversion.
+    std::ranges::in_out_result<long, char> y = x;
+    assert(y.in == 2);
     assert(y.out == '\0');
   }
 
@@ -138,4 +139,3 @@
 
   return 0;
 }
-


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117089.399257.patch
Type: text/x-patch
Size: 691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220112/dde12235/attachment-0001.bin>


More information about the libcxx-commits mailing list