[libcxx-commits] [PATCH] D117044: [libc++] [ranges] Implement ranges::cdata

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

Can you also update `docs/Status/RangesPaper.csv`?



================
Comment at: libcxx/include/__ranges/data.h:76
+
+namespace ranges {
+namespace __cdata {
----------------
Is there any reason to close the `ranges` namespace above and then reopen it here?


================
Comment at: libcxx/include/__ranges/data.h:78
+namespace __cdata {
+  struct __fn {
+    template <class _Tp>
----------------
I think we agreed to only indent inside `__cpo` namespaces, so this struct should not have any extra indentation.


================
Comment at: libcxx/include/__ranges/data.h:84
+      noexcept(noexcept(ranges::data(static_cast<const remove_reference_t<_Tp>&>(__t))))
+      -> decltype(      ranges::data(static_cast<const remove_reference_t<_Tp>&>(__t)))
+      { return          ranges::data(static_cast<const remove_reference_t<_Tp>&>(__t)); }
----------------
Question: would `decltype(auto)` work here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117044/new/

https://reviews.llvm.org/D117044