[libcxx-commits] [PATCH] D117043: [libc++] [ranges] Fix a missing auto(x) cast in ranges::data.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 11 11:08:12 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, var-const, philnik, Mordante, jloser, libc++.
Quuxplusone added a project: LLVM.
Herald added a subscriber: kristof.beyls.
Quuxplusone requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Also remove some bogus `std::forward`s. My impression is that these forwards were actually harmless, because `ranges::begin(FWD(t))` is always identical to `ranges::begin(t)` (except when it's ill-formed, and that can't happen in this case). However, they're also superfluous and don't reflect the wording in the standard, so let's eliminate them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117043

Files:
  libcxx/include/__ranges/data.h
  libcxx/test/std/ranges/range.access/data.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/contiguous_range.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117043.399023.patch
Type: text/x-patch
Size: 6967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220111/da59f69f/attachment.bin>


More information about the libcxx-commits mailing list