[libcxx-commits] [PATCH] D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D116957#3234633 <https://reviews.llvm.org/D116957#3234633>, @ldionne wrote:

> I think we should somehow merge this with `test/support/nasty_macros.h`. Either add these macros to `nasty_macros.h` (but that would probably break a lot of our test suite), or instead remove `nasty_macros.h` and move the macros defined therein into this test. I think the latter would be better.

I did try editing `nasty_macros.h` first, because I assumed that would work; but indeed it broke tons of tests. `nasty_macros.h` is `-include`d on every single test in the test suite, which means those "nasty" macros are poison to use both in libcxx/include/ //and in the tests themselves//.

I'll merge `nasty_macros.h` into this test, and eliminate the mentions of `nasty_macros.h` from `libcxx/test/configs/llvm-libc++-*.cfg.in`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116957/new/

https://reviews.llvm.org/D116957