[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

[Louis Dionne via Phabricator via libcxx-commits]

ldionne edited reviewers, added: var-const; removed: ldionne.
ldionne added inline comments.


================
Comment at: libcxx/include/algorithm:20-38
+namespace ranges { // since C++20
+  template<class I1, class I2>
+  struct in_in_result {
+    [[no_unique_address]] I1 in1;
+    [[no_unique_address]] I2 in2;
+
+    template<class II1, class II2>
----------------
Quuxplusone wrote:
> Defer to @ldionne's opinion on this, but I wonder if it would suffice to replace lines 20–38 with
> ```
> template <class I1, class I2>
>   struct ranges::in_in_result;  // since C++20
> ```
> Going into the full level of detail for every single result type here in this synopsis comment is going to take hundreds of lines, for very little benefit that I can discern.
Yeah, I think just mentioning the forward declaration of `in_in_result` is enough, like we appear to be doing in the current version of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278