[libcxx-commits] [PATCH] D116958: [libc++] Alphabetize CMakeLists.txt and module.modulemap; enforce in CI.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 398823.
Quuxplusone added a comment.

Experimenting with @ldionne's suggested approach. This works for me locally; let's see if buildkite likes it.  I have temporarily added some misalphabetizations in all the places that should be caught by these tests; therefore I expect 3 tests to fail in buildkite, with nice helpful messages identifying all the misalphabetizations.

FWIW, I don't know if @arichardson's concern is justified or not. The easiest way to find out might be to ship this and see if it breaks any buildbots?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116958/new/

https://reviews.llvm.org/D116958

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__debug
  libcxx/include/__iterator/ostream_iterator.h
  libcxx/include/algorithm
  libcxx/include/module.modulemap
  libcxx/test/libcxx/lint/lint_cmakelists.sh.py
  libcxx/test/libcxx/lint/lint_headers.sh.py
  libcxx/test/libcxx/lint/lint_modulemap.sh.py
  libcxx/test/libcxx/lint/lit.local.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116958.398823.patch
Type: text/x-patch
Size: 7012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220111/d3f71db9/attachment.bin>