[libcxx-commits] [PATCH] D116974: [libc++] Add ranges::in_fun_result

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 16:06:56 PST 2022


philnik marked an inline comment as done.
philnik added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:32
   __algorithm/in_in_result.h
+  __algorithm/in_fun_result.h
   __algorithm/is_heap_until.h
----------------
Quuxplusone wrote:
> Here and modulemap, please alphabetize.
> Good news: I'll render this nit unnecessary Real Soon Now via however D116958 ends up.
I've already looked at D116958. Thanks for that!


================
Comment at: libcxx/test/std/algorithms/algorithms.results/no_unqiue_address.compile.pass.cpp:1
 //===----------------------------------------------------------------------===//
 //
----------------
Quuxplusone wrote:
> Please fix the spelling of this file's filename, at some point (here or elsewhere or just as an NFC commit).
This file was introduced in D116278. I'll fix it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116974/new/

https://reviews.llvm.org/D116974



More information about the libcxx-commits mailing list