[libcxx-commits] [PATCH] D116974: [libc++] Add ranges::in_fun_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a subscriber: var-const.
Quuxplusone added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:32
   __algorithm/in_in_result.h
+  __algorithm/in_fun_result.h
   __algorithm/is_heap_until.h
----------------
Here and modulemap, please alphabetize.
Good news: I'll render this nit unnecessary Real Soon Now via however D116958 ends up.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_fun_result.pass.cpp:20-26
+struct MoveOnly {
+  MoveOnly() = default;
+  MoveOnly(const MoveOnly&) = delete;
+  MoveOnly(MoveOnly&& o) { o.movedFrom = true; }
+
+  bool movedFrom = false;
+};
----------------
Could this plausibly use the `MoveOnly` type from `test/support/moveonly.h` instead, just to reduce the line count a bit?
(Ditto consistently in the `in_in_result` PR, if it also applies there; and in @var-const's PR that includes `in_out_result`. I hadn't noticed this nit before.)


================
Comment at: libcxx/test/std/algorithms/algorithms.results/no_unqiue_address.compile.pass.cpp:1
 //===----------------------------------------------------------------------===//
 //
----------------
Please fix the spelling of this file's filename, at some point (here or elsewhere or just as an NFC commit).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116974/new/

https://reviews.llvm.org/D116974