[libcxx-commits] [PATCH] D116045: [libc++][ABI BREAK] Start using `arc4random()` to implement `std::random_device` on Apple

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 14:05:54 PST 2022


ldionne added a subscriber: emaste.
ldionne added a comment.

This version of the patch relaxes the `std::random_device` constructor so it doesn't error out when a custom token is passed, which eases transition to `arc4random()` for vendors who have already shipped `std::random_device` with a different implementation.

@emaste do you know who's responsible for OpenBSD? This is technically a small behavior change on their platform since an invalid custom token is going to be ignored instead of throwing an exception. That's most likely OK but we might as well double check with them if we can get a hold of someone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116045/new/

https://reviews.llvm.org/D116045



More information about the libcxx-commits mailing list