[libcxx-commits] [PATCH] D116958: [libc++] Alphabetize CMakeLists.txt and module.modulemap; enforce in CI.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 12:22:51 PST 2022


ldionne added inline comments.


================
Comment at: libcxx/utils/CMakeLists.txt:31-32
             libcxx-generate-private-header-tests
+            libcxx-lint-cmakelists
+            libcxx-lint-modulemap
     COMMENT "Create all the auto-generated files in libc++ and its tests.")
----------------
Note that the fact that we'd be running tests as part of a target that generates files is what got me to suggest the alternative approach with a shell test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116958/new/

https://reviews.llvm.org/D116958



More information about the libcxx-commits mailing list