[libcxx-commits] [PATCH] D116642: [libc++] Implement operator<< for filesystem::directory_entry.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/filesystem:48-51
+    // The fs.dir.entry.io operator is a friend of directory_entry.
+    template<class charT, class traits>
+      friend basic_ostream<charT, traits>&
+        operator<<(basic_ostream<charT, traits>& os, const directory_entry& d);
----------------
Quuxplusone wrote:
> The extra `//` comment here was the red flag for me; but actually I think this entire diff is unnecessary. This `operator<<` is specified inside the body of `class directory_entry`; the body of `directory_entry` is not shown here; therefore this `operator<<` needn't be shown here.
> So I believe no change is needed anywhere in this particular file.
I'd agree with this, unless we want to detail all of `class directory_entry` in the synopsis, which might not be a bad idea. No strong preference here -- I don't think we have consistency about this in the library (but we seem to consistently *not* detail the classes in this header).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116642/new/

https://reviews.llvm.org/D116642