[libcxx-commits] [PATCH] D116958: [libc++] Alphabetize CMakeLists.txt and module.modulemap; enforce in CI.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, Mordante, philnik, ChuanqiXu, libc++.
Quuxplusone added a project: libc++.
Herald added subscribers: kristof.beyls, arichardson, mgorny.
Quuxplusone requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: libcxx-commits, sstefan1.
Herald added 1 blocking reviewer(s): libc++.

Following up on @philnik's suggestion in D116809 <https://reviews.llvm.org/D116809>. Is this too much extra bureaucratic code for too little gain? I'm not sure, but it doesn't seem like a //crazy// amount of bureaucratic code.

Here, as in D116809 <https://reviews.llvm.org/D116809>, I'm assuming that Python3 string comparisons (for ASCII characters) are sane and unaffected by locale in any way that would harm us. It'd be awesome if some Python guru could confirm or deny that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116958

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/module.modulemap
  libcxx/utils/CMakeLists.txt
  libcxx/utils/lint_cmakelists.py
  libcxx/utils/lint_modulemap.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116958.398690.patch
Type: text/x-patch
Size: 11437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220110/8a375193/attachment-0001.bin>