[libcxx-commits] [PATCH] D116947: [libc++] Introduce __debug_db_insert_c()

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D116947#3231722 <https://reviews.llvm.org/D116947#3231722>, @Quuxplusone wrote:

> @ldionne has already accepted, but FWIW, I would have said let's //not// introduce a new function-call layer of indirection for this, because that harms `-O0` codegen (not that we //really// care about `-O0` codegen). I would have suggested a macro, or just not doing this at all. Food for thought maybe?

IMO we should try not to use macros when we have an easy alternative. And as you said, codegen at `-O0` is not something that has a lot of weigh in the balance. I certainly wouldn't want to start making regular decisions based on that, at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116947/new/

https://reviews.llvm.org/D116947