[libcxx-commits] [PATCH] D116947: [libc++] Introduce __debug_db_insert_c()

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 10 08:09:04 PST 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__debug:271
 
+void _LIBCPP_HIDE_FROM_ABI __debug_db_insert_c(void* __c) {
+#if _LIBCPP_DEBUG_LEVEL == 2
----------------
You also probably want to make it `constexpr` after C++11?


================
Comment at: libcxx/include/list:872
     {
-#if _LIBCPP_DEBUG_LEVEL == 2
-        __get_db()->__insert_c(this);
-#endif
+        __debug_db_insert_c(this);
     }
----------------
All of these calls should be `_VSTD::__debug_db_insert_c`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116947/new/

https://reviews.llvm.org/D116947



More information about the libcxx-commits mailing list