[libcxx-commits] [PATCH] D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D115906#3225588 <https://reviews.llvm.org/D115906#3225588>, @DanielMcIntosh-IBM wrote:

> Should this have used `_LIBCPP_THREAD_ABI_VISIBILITY` instead? Won't this break `_LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL`? Also, why is this needed when the forward declarations already specify that the functions are inline?

For the Pthread case, using `_LIBCPP_THREAD_ABI_VISIBILITY` and `inline _LIBCPP_HIDE_FROM_ABI` is equivalent. However your'e right, this doesn't look necessary to me after all since they are all forward declared above with the correct visibility anyways. I find this code rather confusing and I'm going to refactor it to disentangle the different implementations.

I'm not sure how this change would break `_LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL` though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115906/new/

https://reviews.llvm.org/D115906