[libcxx-commits] [PATCH] D116883: [libcxx][test] Auto-detect _LIBCPP_HAS_NO_UNICODE for MSVC STL

Mon Jan 10 05:36:03 PST 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM. In the future, we should create a `TEST_HAS_NO_UNICODE` macro in `test_macros.h` and use that throughout the test suite instead (like we do for `TEST_HAS_NO_WIDE_CHARACTERS`).

================
Comment at: libcxx/test/support/msvc_stdlib_force_include.h:109
+#define _LIBCPP_HAS_NO_UNICODE 1
+#endif // defined(_MSVC_EXECUTION_CHARACTER_SET) && _MSVC_EXECUTION_CHARACTER_SET != 65001
+
----------------
For such a small `#if` - `#endif` block, I would drop the closing comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116883/new/

https://reviews.llvm.org/D116883