[libcxx-commits] [PATCH] D116880: [libcxx][test] Make LIBCPP_STATIC_ASSERT usable at namespace scope

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM%comment.



================
Comment at: libcxx/test/support/test_macros.h:239-243
 #define LIBCPP_ASSERT(...) ((void)0)
-#define LIBCPP_STATIC_ASSERT(...) ((void)0)
+#define LIBCPP_STATIC_ASSERT(...) static_assert(true, "")
 #define LIBCPP_ASSERT_NOEXCEPT(...) ((void)0)
 #define LIBCPP_ASSERT_NOT_NOEXCEPT(...) ((void)0)
 #define LIBCPP_ONLY(...) ((void)0)
----------------
I think you're onto something here. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116880/new/

https://reviews.llvm.org/D116880