[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jan 9 02:23:37 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_result.pass.cpp:74-79
+  {
+    std::ranges::in_in_result<MoveOnly, Empty> res;
+    assert(!res.in1.movedFrom);
+    [[maybe_unused]] auto res2 = static_cast<std::ranges::in_in_result<MoveOnly, Empty>>(std::move(res));
+    assert(res.in1.movedFrom);
+  }
----------------
Nit: If you `s/Empty/int/` on lines 75–77, then you don't need line 34 at all in this file anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278



More information about the libcxx-commits mailing list