[libcxx-commits] [PATCH] D116808: fix __simple_view concept in std::ranges

[Hui via Phabricator via libcxx-commits]

huixie90 added a comment.

@Quuxplusone

I added tests for `take_view` as it has observable behaviour change. For other views, I can't seem to find observable things. As `simple-view` concept is really about removing the non-const overload if it is same as the `const` overload. The only thing I am thinking of testing is that if `simple-view<BaseView>` is satisfied, we can check if it only has one overload of `begin`. I tried different things
https://godbolt.org/z/W6vsjdG95
https://godbolt.org/z/jbnKf4Yqv
https://godbolt.org/z/j6GP1bMnb

But compilers don't all agree and in one case, it even triggers clang to ICE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116808/new/

https://reviews.llvm.org/D116808