[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_result.pass.cpp:13-14
+
+// clang-cl and cl currently don't support [[no_unique_address]]
+// XFAIL: msvc
+
----------------
I just checked the build results, and it looks like the //only// problem with this test is that it checks something like `sizeof(in_in_result<Empty, int>) == sizeof(int)`, which we expect to fail on MSVC. So you should just guard that one test under an appropriate `#if`, or IMO even better, split that test case out into `in_in_result.no_unique_address.pass.cpp` and XFAIL only that file. At the same time you can expand the test coverage to test `sizeof(in_in_result<int, Empty>)` and `sizeof(in_in_result<Empty, Empty>)` too!


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_result.pass.cpp:37
+
+struct S2 {};
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278