[libcxx-commits] [PATCH] D116815: [libc++] basic_string::resize_and_overwrite: Adopt LWG3645 (Not voted in yet)

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 7 10:15:27 PST 2022


Quuxplusone added a comment.

FWIW, //I// think this is a good idea (and might motivate LWG to DTRT), but I'm biased. Let's see what @ldionne thinks.
Also, I don't know if @ldionne would want us to mention LWG3645 in some csv file, or say nothing until it's adopted (and of course that question becomes moot if we just defer landing this at all).



================
Comment at: libcxx/test/std/strings/basic.string/string.capacity/resize_and_overwrite.pass.cpp:79
+  s.resize_and_overwrite(10, [](char*&&, size_t&&) { return 0; });
+  s.resize_and_overwrite(10, [](char* const&, const size_t&) { return 0; });
   struct RefQualified {
----------------
You could actually add line 79 to the test today, right? It should work both before and after this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116815/new/

https://reviews.llvm.org/D116815



More information about the libcxx-commits mailing list