[libcxx-commits] [PATCH] D116809: [libc++] Alphabetize headers, and enforce the order in buildkite. NFCI.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

Running `clang-tidy double_include.sh.cpp -header-filter=.* -system-headers -- -nostdinc++ -I ../../../build/include/c++/v1/ -std=c++2b` it complains about

- the ranges namespaces (which I find reasonable)
- non-inline variables in `reverse_view.h` (they are `constexpr`, so this seems to be a clang-tidy bug)
- a bunch of include-order problems in non-libc++ system headers (I don't know how to only get the results for our headers)
- 1 include-order warning in `__filesystem/path.h` (It doesn't like the `<locale>` and `<iomanip>` order)
- `misc-redundant-expression` in `__iterator/iterator_traits.h:201` (this looks very suspicious, but I don't know if that is a bug)

There are about 30 libc++-related warnings total, most of which are the ranges namespace comments. So I think it is, with the clang-tidy bug fixed, quite reasonable to enable clang-tidy for our `include/`-files.
I haven't checked `src/` fully, but just going through a few headers, it seems to almost exclusively be include order and namespace comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116809/new/

https://reviews.llvm.org/D116809