[libcxx-commits] [PATCH] D116808: fix __simple_view concept in std::ranges

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Ah, I see; thanks @philnik! This looks like a real bugfix then. Thankfully, it looks like we have test coverage for this case — so this PR also needs to update some existing tests, but might not need to add many (if any) //new// tests.

OTOH, it looks like `__simple_view` is used inside `take_view`, `drop_view`, and `join_view`, and //none// of those tests are failing. This indicates missing test coverage for those view adaptors.



================
Comment at: libcxx/include/__ranges/concepts.h:85
+  concept __simple_view = view<_Range> && range<const _Range> &&
+      same_as<iterator_t<_Range>, iterator_t<const _Range>> && same_as<sentinel_t<_Range>, sentinel_t<const _Range>>;
 
----------------
miscco wrote:
> If you want to you can also give clang format a nudge by adding `//` where you want a line break
> 
> That said I do not know whether this is usually accepted here
It's not usually accepted to //commit// code with random empty `//` comments. :)
Anyway, in this case the right answer is "don't run clang-format."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116808/new/

https://reviews.llvm.org/D116808