[libcxx-commits] [PATCH] D116808: fix __simple_view concept in std::ranges

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D116808#3227470 <https://reviews.llvm.org/D116808#3227470>, @huixie90 wrote:

> In D116808#3227463 <https://reviews.llvm.org/D116808#3227463>, @Quuxplusone wrote:
>
>> Please undo your formatting changes, so that the code change is easier to find in the diff (and also because the old formatting was strictly better). I actually don't see what your proposed difference is right now at all — it looks identical?
>
> I am not sure about the process and I am happy to undo the formatting change. But I followed the instructions of the contribution guide and used the "arc" tool for the review and the tool suggested me to lint the code in this way and automatically applied the formatting fix.
>
> the actual change is the last bit is changed from `iterator_t` -> `sentinel_t`
>
> anyway. should I surround the code  //clang-format off with //clang-format on after revert the formatting?

Just use `--nolint` with arc. Don't add `//clang-format`. Almost no file in libc++ is conforming to the clang-format rules. It is not the most useful in libc++, because we have much weird stuff which clang-format just doesn't format properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116808/new/

https://reviews.llvm.org/D116808