[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__algorithm/in_in_result.h:13-14
+
+#include <__config>
+#include <__concepts/convertible_to.h>
+#include <__utility/move.h>
----------------
philnik wrote:
> Quuxplusone wrote:
> > Swap these two lines. (One of these days I'll make `graph_header_deps.py` just check for a-z order.)
> You know there is a clang-tidy check for that, right? Maybe we should just enforce the clang-tidy checks at some point?
Just posted D116809! If you have the ability to run clang-tidy locally, it'd be interesting to see what it says about that branch. Like, is clang-tidy happy with that branch, or would it still complain — and if so, do you think its remaining complaints are valid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278